[Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow #17961
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
reviewed
Feb 6, 2026
Comment on lines
+296
to
+302
| try { | ||
| validateGlobalParams(globalParams); | ||
| } catch (ServiceException ex) { | ||
| log.warn("Invalid globalParams: {}", ex.getMessage()); | ||
| putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, ex.getMessage()); | ||
| return result; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| try { | |
| validateGlobalParams(globalParams); | |
| } catch (ServiceException ex) { | |
| log.warn("Invalid globalParams: {}", ex.getMessage()); | |
| putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, ex.getMessage()); | |
| return result; | |
| } | |
| validateGlobalParams(globalParams); |
Directly throw ServiceException at validateGlobalParams, please don't use a lot of try catch here.
Comment on lines
+899
to
+901
| if (Direct.IN.equals(p.getDirect()) && StringUtils.isEmpty(p.getValue())) { | ||
| throw new ServiceException("IN param value required for key: " + key); | ||
| } |
Member
There was a problem hiding this comment.
We should support the value to be null.
| /** | ||
| * Validates global parameters: non-empty keys, no duplicates, and required values for IN-type params. | ||
| */ | ||
| private void validateGlobalParams(String globalParams) { |
Member
There was a problem hiding this comment.
We shouldn't be writing this kind of glue code everywhere. Why not use a GlobalParamValidator to handle this task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17960
Brief change log
Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md